Cherry-pick #19812 to 7.8: [Bug] fix bug with empty filter values returning no results in system/service #19914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/service (elastic#19812) * fix bug with empty filter values returning no results * add changelog entry (cherry picked from commit a1dd2ec)
fearful-symmetry
added
[zube]: In Review
backport
Team:Integrations
botelastic
bot
added
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
removed
the
needs_team
|
This pull request doesn't have a |
kaiyan-sheng
approved these changes
Jul 14, 2020
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…/service (elastic#19812) (elastic#19914) * fix bug with empty filter values returning no results * add changelog entry (cherry picked from commit 1e531b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #19812 to 7.8 branch. Original message:
What does this PR do?
This fixes a bug where if the system/service module is running on an OS with an older version of systemd, and a user hasn't configured
pattern_filter, the metricset will return no results. When using the systemdListUnitsFilteredAPI call, we don't bypass the pattern_filter in cases where the filter is empty.Why is it important?
It's a bug, the metricset won't return any data.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
system/servicemetricsetservice.pattern_filterisn't configured.